*: add ManagementState support to controllers#29
Merged
openshift-merge-robot merged 6 commits intoopenshift:masterfrom Nov 5, 2019
Merged
*: add ManagementState support to controllers#29openshift-merge-robot merged 6 commits intoopenshift:masterfrom
openshift-merge-robot merged 6 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
approved
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
hexfusion
force-pushed
the
add_management
branch
from
ff34c72 to
8f599f5
Compare
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
3 tasks
hexfusion
force-pushed
the
add_management
branch
from
753414d to
c69b293
Compare
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
hexfusion
force-pushed
the
add_management
branch
from
fac77a3 to
00f52c9
Compare
Contributor
|
/lgtm |
openshift-ci-robot
added
lgtm
hexfusion
force-pushed
the
add_management
branch
from
f57b3d7 to
762cef0
Compare
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
hexfusion
force-pushed
the
add_management
branch
from
762cef0 to
113e59e
Compare
Contributor
Author
|
/hold cancel |
openshift-ci-robot
added
lgtm
|
/lgtm |
hexfusion
force-pushed
the
add_management
branch
from
6a03df5 to
b186dd6
Compare
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
hexfusion
force-pushed
the
add_management
branch
from
b186dd6 to
4ac04a5
Compare
Contributor
|
/lgtm |
alaypatel07
approved these changes
Nov 5, 2019
Contributor
alaypatel07
left a comment
alaypatel07
left a comment
There was a problem hiding this comment.
I am creating related issues to clean up some stuff, but for now
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaypatel07, hexfusion, retroflexer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
cluster-etcd-operatorto CVO in an Unmanaged state. This is a temporary state until the installer changes can merge and then allows us to test scale with operator with one PR against this repo changing theManagedwith the addition of a PR to MCO.Signed-off-by: Sam Batschelet sbatsche@redhat.com